Skip to content

remove redundant second await in ast_await #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

remove redundant second await in ast_await #688

merged 1 commit into from
Jan 21, 2025

Conversation

@dmamelin
Copy link
Contributor

Fixes #643, #673

Code to reproduce:

async def test3(): return "test3" @time_trigger("startup") async def test1(): await test3()

TypeError: object str can't be used in 'await' expression
@craigbarratt craigbarratt merged commit 9465f98 into custom-components:master Jan 21, 2025
6 checks passed
craigbarratt added a commit that referenced this pull request Jan 22, 2025
@craigbarratt
improved fix from #688, but still pyscript doesn't
8ee7926 
correctly handle async function declarations and creating coros when you call them without await.
@craigbarratt craigbarratt mentioned this pull request Jan 22, 2025
Closed
@vladikoff vladikoff mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@dmamelin @craigbarratt