Addition of Bicycle Power profile #28
Conversation
Added Bicycle Power profile initial draft, working with Favero Assioma Duo pedals. Most measurements will require post-processing, but data is received. Didn't see that there was already development work on this profile otherwise I would have started from existing work.
There was a problem hiding this comment.
overall looks very good (without checking against spec yet), just some indentation and need to your example to the travis build. I will do another review later this week in detail with the spec in hand just to verify, if all goes well we can merge this. If you desire and have the time you are welcome to add some additional commits to fixup any comments.
| | ||
| /* Crank Torque Frequency Main Data Page | ||
| | ||
| NOTE: CTF messages are big endian. The byte order for multi-byte |
There was a problem hiding this comment.
the helper functions can handle any endianess
There was a problem hiding this comment.
That is why in >8 bit values you can specify LSB and MSB :)
There was a problem hiding this comment.
not to self to implement this.
There was a problem hiding this comment.
Missing messages
- General calibration request
- general calibration response
- Auto Zero Support
- custom parameters page
- tf define calibration (and response page)
- Save Slope to Flash Main Data Page (and response)
- Torque Frequency Request to Save Serial Number in Flash (and repsonse)
- Get/Set Parameter
- Crank Parameters
- Power Phase Config
- Rider position config
- Advanced Capabilities
- Advanced Capabilities 2
- Measurement output
- Cycling Dynamics
- Left force angle
- Pedal position data
- torque barycenter
Jeez i forgot how crazy this profile is. Ok i think its safe to say calibration is out of the question for the time being.
Thanks for the contribution, I will go ahead, merge this, fix minor formatting and naming issues, replace common datapages with share code versions then handle merge conflicts. I will leave these comments for myself as a TODO list.
src/Profiles/BicyclePower/DataPages/Base/ANTPLUS_BicyclePowerBasePowerOnly.cpp Show resolved Hide resolved
| } | ||
| | ||
| void powerOnlyDataPageHandler(BicyclePowerPowerOnly& msg, uintptr_t data) { | ||
| Serial.print("Pedal Balance: "); |
There was a problem hiding this comment.
note to self break out pedal differentiation bit and add method to check for "not used" case
src/Profiles/BicyclePower/DataPages/Base/ANTPLUS_BicyclePowerBasePowerOnly.cpp Show resolved Hide resolved
2 participants
Addition of profiles for Power Only, Crank Torque, Wheel Torque. Crank Torque Frequency not included.