antplus arduino power profile

[sporkfly]

Addition of power profile for Power Only, Crank Torque, and Wheel Torque for display. Display example included. Rx only, not Tx messages. Parameters, manual zero, etc. not included. CTF not included (not able to verify profile, does not fit bye ordering of ANT+ standard profiles). Wheel torque will require verification with a wheel/hub based power meter. Power only and crank torque verified with Favero Assioma Duo pedals.

[cujomalainey]

Hi @sporkfly

Thank you for the contribution, it is appreciated :) the master branch is reserved for releases. I would love to get this integrated so we have 2 paths forward.

1. We close this PR and rebase on the develop branch. It will likely conflict with the existing incomplete bicycle power sensor code there so you would have to handle the conflicts.
2. I cut a branch a branch that doesn't have the bicycle power code, we merge this code to that branch and I handle the merge conflicts.

I am good with either. I will do a full review once we decide path forward. Thanks again for the contribution.

[cujomalainey]

If i dont here back by friday i will merge this, and rebase the code into develop and follow path 2.

[sporkfly]

Hey Curtis, Sorry for the late reply, my work life is very demanding right now. I put this profile together over my holiday, so option 2 is fine with me as I'm not sure when I'll have time to work on it again. Let me know what you need on my end - I'm new to using Git. Andrew

…

On Wed, Jan 6, 2021, 2:08 AM Curtis Malainey ***@***.***> wrote: If i dont here back by friday i will merge this, and rebase the code into develop and follow path 2. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASISZ5QJYBVEOU3IVIC4AX3SYQD65ANCNFSM4VO2VJ2Q> .

[cujomalainey]

No worries, I know the email flood life. Work is keeping me busy as well which is why I haven't had much chance this holiday to work on this either. I appreciate you sharing the code though.

I created a branch called merge/sporkfly can you create a new PR that targets that branch? Unfortunately github will not allow me to change branches on an existing PR. I can fixup anything when I get the time and merge into develop.

[sporkfly]

Pull request against merge/sporkfly created.