feat(PrismCode): react renderer #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 40f565a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for cube-uikit-docs failed.
|
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-48ab13c. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏗 Docs are successfully deployed!👀 Preview: https://683f2da9f274be0cfa1ac8c8--cube-uikit-docs.netlify.app |
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces direct PrismJS usage with prism-react-renderer for syntax highlighting in the PrismCode component.
- Switch from
Prism.highlightAllto<Highlight>fromprism-react-rendererand manual token rendering - Bridge the renderer’s Prism instance to global and dynamically import grammars
- Update dependencies to include
prism-react-renderer
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/components/content/PrismCode/PrismCode.tsx | Replace PrismJS usage with prism-react-renderer and dynamic grammar imports |
| package.json | Add prism-react-renderer dependency |
| .changeset/fair-turtles-switch.md | Note change of rendering engine in changelog |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/components/content/PrismCode/PrismCode.tsx:87
- This new rendering logic isn't covered by existing tests. Consider adding unit or snapshot tests for both standard code blocks and diff highlighting scenarios to prevent regressions.
function PrismCode(props: CubePrismCodeProps, ref) { 
tenphi had a problem deploying to Canary package in NPM 
GitHub Actions Failure tenphi had a problem deploying to Canary package in NPM GitHub Actions Failure tenphi had a problem deploying to Canary package in NPM GitHub Actions Failure 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.