method_missing monkey patch breaks Rails DynamicFinder #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This issue is actually not a problem with annotate_models, because the patch is only intended to load when calling the annotation rake task. However, it is making it difficult to create an extension - see pinnymz/migration_comments#2 |
| Refactoring the patch to a separate file was the simplest solution I could come up with, please let me know if you come up with any better options |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If the annotate gem happens to be loaded into the environment, the dynamic finders (find_by_name, find_by_id, etc.) will always return nil.