Refactor AnnotateModels::Helpers #723
Merged
+2 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nard-tech commented Jan 17, 2020
| return false unless val =~ Constants::TRUE_RE | ||
| | ||
| true | ||
| val.present? && Constants::TRUE_RE.match?(val) |
There was a problem hiding this comment.
def true?(val) return false if val.blank? return false unless val =~ Constants::TRUE_RE truecan be refactored to
def true?(val) if val.blank? false else if val =~ Constants::TRUE_RE true else false end end endSo we can easily replace them to a one liner method.
I used Regexp#match? instead of String#=~ because String#=~ returns nil or an integer.
drwl approved these changes Jan 18, 2020
| return false unless val =~ Constants::TRUE_RE | ||
| | ||
| true | ||
| val.present? && Constants::TRUE_RE.match?(val) |
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
I refactored two methods in AnnotateModels::Helpers for readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I refactored two methods in AnnotateModels::Helpers for readability.