Refactor hooking ActiveRecord migration tasks #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Use Rake::Task#enhance insteaad of defining same tasks again - Remove hooking db:migrate:change task which doesn't exist - Fix hooking db:migrate:reset task so that the annotation runs after all migration tasks (ctran#548)
| Thanks!!! |
onk added a commit to onk/annotate_models that referenced this pull request Dec 3, 2020
ActiveRecord's migrate tasks are required since v2.7.5 (ctran#588).
onk added a commit to onk/annotate_models that referenced this pull request Dec 3, 2020
ActiveRecord's migrate tasks are required since v2.7.5 (ctran#588).
ctran pushed a commit that referenced this pull request Jan 3, 2021
ActiveRecord's migrate tasks are required since v2.7.5 (#588).
ocarta-l pushed a commit to ocarta-l/annotate_models that referenced this pull request Jun 18, 2021
) ActiveRecord's migrate tasks are required since v2.7.5 (ctran#588).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added 3 changes:
Use
Rake::Task#enhanceinsteaad of defining same tasks again.Remove hooking
db:migrate:changetask which doesn't exist. This hook has been added by Support :change migrations in Rails 3.1 #42, but as far as I searched I can't find the task in Rails 3.1 or greater version.Fix hooking
db:migrate:redotask so that the annotation runs after all migration tasks. Closedb:migrate:redoreverses the annotation but doesn't redo it #548.This is done by hooking the top level task to run the annnotation. (ref: https://stackoverflow.com/a/3915951)