Skip to content

Don't crash on inherited models in subdirectories. #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2015
Merged

Don't crash on inherited models in subdirectories. #232

merged 1 commit into from
Mar 4, 2015

Conversation

CyborgMaster
Copy link
Contributor

We need to make sure a file exists before trying to require it. Fixes #200.
@CyborgMaster CyborgMaster changed the title Don't crash if file doesn't exist Don't crash on inherited models in subdirectories. Feb 26, 2015
@CyborgMaster CyborgMaster mentioned this pull request Feb 26, 2015
Closed
@ctran
Copy link
Owner

ctran commented Feb 27, 2015

Thanks. Do you know why Travis CI is not happy about this PR?
@CyborgMaster
Copy link
Contributor Author

I was surprised to see it fail, it was such a small change. I'll look into it now.
@CyborgMaster
Copy link
Contributor Author

Don't merge this yet, I got the tests to pass again, but now it's not fixing the bug
@CyborgMaster
Copy link
Contributor Author

Alright, the tests pass and the bug is fixed. Feel free to merge.
@ctran
Copy link
Owner

ctran commented Mar 2, 2015

Thanks a lot. Would you mind rebase your changes into a single commit? I'm kind a stickler for clean history :-)
@CyborgMaster
Copy link
Contributor Author

Sure, doing it now.
@CyborgMaster
Copy link
Contributor Author

K, history squashed.
ctran added a commit that referenced this pull request Mar 4, 2015
@ctran
Merge pull request #232 from CyborgMaster/models-in-subdirectories
6464fc0 
Don't crash on inherited models in subdirectories.
@ctran ctran merged commit 6464fc0 into ctran:develop Mar 4, 2015
@CyborgMaster
Copy link
Contributor Author

Could we get a bugfix release pushed to rubygems? That way I can delete my fork.
@ctran
Copy link
Owner

ctran commented Mar 5, 2015

Sure, I will do that this weekend.
On Wed, Mar 4, 2015 at 6:56 AM CyborgMaster notifications@github.com
wrote:

Could we get a bugfix release pushed to rubygems? That way I can delete me
fork.

—
Reply to this email directly or view it on GitHub
#232 (comment).
@ctran ctran added the released label Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released
2 participants
@CyborgMaster @ctran