fix for require statements in tasks #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| What's your version of Rails and annotate that you have this problem with? |
| I'm running Ruby 1.8.7 Enterprise Edition under RVM. rails (2.3.2) Unfortunately I don't have Bundler wired up for this project. |
| I have the same problem here... |
| I'm using Rails 2.3.9 with bundler! |
| I have this same problem after I switched to bundler. The patches fix it. |
There was a problem hiding this comment.
I'm not sure this is the right way to fix this. I'd avoid doing a require with full path.
There was a problem hiding this comment.
require with full path is supposed to be OK in Ruby 1.9 -- it won't require the same file twice no matter what (knock wood)
ctran added a commit that referenced this pull request Jun 8, 2011
fix for require statements in tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
After installing the annotate gem and attempting to run annotate on my project, I received the following error:
no such file to load -- annotate/annotate_models (MissingSourceFile)
To correct the problem, I simply updated the require statements in the tasks to use a fully qualified path to the needed files. I've tested this with success locally, but my tests have not been formal or robust... basically 1 developer machine with the patch applied.
It would be great to have this fix deployed in later versions of the gem, so I don't have to tweak the gem after installation though.
Thanks for considering my patch.
--Nathan