Coerce class to string for comparison #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes ctran#173, by ensuring that the model is coerced to a string before it's run through `ActiveSupport::Inflector.underscore`, which then correctly compares to the filename (which is a string already).
| 👍 |
| I'm unsure why the standalone scenario fails. I can't seem to find where this is defined. Probably this is an issue with my Travis skills, since I don't use it on a regular basis. |
| It started to fail before your change. I'll take a look. |
| Thanks 👍 |
ctran added a commit that referenced this pull request Jun 14, 2014
Coerce class to string for comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #173, by ensuring that the model is coerced to a string before it's run through
ActiveSupport::Inflector.underscore, which then correctly compares to the filename (which is a string already).