fix overwriting of namespaced model test annotations with non-namespaced model annotations #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
the special-purpose file resolution method for test/spec files was failing with namespaced test files (ex. User model attributes would annotate both test/unit/user_test.rb as well as test/unit/foo/user_test.rb, instead of only the former)
changing to get rid of deprecation warnings
| Thanks for the patch. I will try to merge it in this weekend. |
ctran added a commit that referenced this pull request Feb 24, 2014
fix overwriting of namespaced model test annotations with non-namespaced model annotations
| thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
the test-file specific find_test_file method was matching namespaced model files when annotating non-namespaced models; using the same file resolution method for all file types fixes this.
e.g: with a User and a Foo::User model, User annotations were applied to both test/unit/user_test.rb as well as test/unit/foo/user_test.rb (order of operation was a factor here - if the non-namespaced model was annotated first this effect was not seen, as the namespaced annotations would overwrite and hide the issue)
Also, switched "mock" for "double" to kill deprecation warnings in specs