Fix non-relative pathname detection #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Yes please, merge this. Just ran in to the same problem and found the very same issue |
| Oh, sorry guys, didn't notice it. Anyways published it in 4.0.2. Thank you for your effort! |
| Great, and thank you @dallonf for providing a good solution |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When composing a style from a CSS file in a scoped module, the hook would previously not detect that this was not a relative path due to it starting with
@.A quick trip to StackOverflow later, I think this updated regex will now correctly detect all non-relative paths.