document inspection #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
Owner
| I tested your implementations and all seems good. To avoid too much content in the display area, I might move the two new inputs to the sidebar. For the third bullet point you mentioned above, I don't see this as a super important new feature for now. Thanks for contributing again! |
Contributor Author
| Great! Thanks for merging. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#14 was implemented
The first two bullet points were implemented, but the third one is more difficult. Some design decisions need to be made, as a threshold and a condition cannot be applied simultaneously - I welcome anyone trying to implement it, but for now I will leave it as is.