Preserve models from unconfigured providers when updating #543
+873 −193
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this does
This fixes an issue where models from unconfigured providers are not preserved when running rake models:update.
Since calling
Models.refresh!refetches the list of models and fully replaces the old list, it will also completely skip unconfigured providers in the new list (except if they're coming from parsera as well).This change ensures that configured providers are fetched fresh and unconfigured ones are preserved as they are. This allows partial model updating.
Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecI updated documentation if needednot neededmodels.json,aliases.json)API changes
Related issues
No linked issues.