Install clang-tools into current pre-commit venv #29
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I tried fixing #28, but this turned into a somewhat larger refactor, as I found a couple of more issues.
First:
try-repo
doesn't actually support running the current code and it doesn't read the config file and it doesn't support passing args. There are a couple of issues about that in the pre-commit repo, but I didn't find a really good solution.Second: I could simplify the code a lot by using an
ArgumentParser
for the command line args and by using python functions fromclang_tools
instead of using subprocess to call the cli.Let me know what you think.