fix setting of lines-changed-only #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The README states that the value of true focuses on lines in diff with additions only. Setting it to 'diff' will use the original behavior (meaning entire diff chunks with unchanged lines). However, I forgot to change this value's interpretation in the src code (& test). This commit makes the README accurate.
Codecov Report
@@ Coverage Diff @@ ## master #90 +/- ## ======================================= Coverage 80.47% 80.47% ======================================= Files 6 6 Lines 630 630 ======================================= Hits 507 507 Misses 123 123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator Author
| Related to #74 (comment) |
shenxianpeng approved these changes Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The README states that the value of true focuses on lines in diff with additions only.
Setting it to 'diff' will use the original behavior (meaning entire diff chunks with unchanged lines).
However, I forgot to change this value's interpretation in the src code (& test).
This commit makes the README accurate.