Skip to content

Use native package managers #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Use native package managers #107

wants to merge 6 commits into from

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Oct 13, 2022 •
edited
Loading

Notes: brew does not support install clang-tidy

Run if [[ "macOS" == "Linux" ]]; then Warning: No available formula with the name "clang-tidy". Did you mean clang-format? ==> Searching for similarly named formulae... This similarly named formula was found:
2bndy5
2bndy5 reviewed Oct 13, 2022
View reviewed changes
action.yml
shell: bash
run: |
if [[ "${{runner.os}}" == "Linux" ]]; then
sudo apt-get install clang-format-${{ inputs.version }} clang-tidy-${{ inputs.version }}
Copy link
Collaborator

@2bndy5 2bndy5 Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing to find v13 & v14 in the apt pkgs list. Maybe, it would help to run apt-get update beforehand?
Copy link
Collaborator Author

@shenxianpeng shenxianpeng Oct 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try when I have chance to open my laptop tomorrow
Copy link
Collaborator Author

@shenxianpeng shenxianpeng Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I used shell if else because composite doesn't support if condition.

Alternative, maybe composite support to call a shell script file.
Copy link
Collaborator

@2bndy5 2bndy5 Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we could use a shell script located in the action repo. I didn't know about the composite steps not supporting if conditions.
@shenxianpeng shenxianpeng deleted the shenxianpeng/use-native-package-106 branch October 26, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@shenxianpeng @2bndy5