Update build.yml to fix macOs build

[shenxianpeng]

Summary by CodeRabbit

• Chores
  • Updated the build process for macOS to refine optimization settings.
  • Enhanced the verification steps by adding version-check displays for output binaries.
  • Standardized naming and comments in build steps for improved clarity.
• New Features
  • Updated compatibility for clang-tidy on macOS 64 to support versions 19 and 20.
  • Removed caution regarding file sizes for clang-tidy binaries, indicating resolution of previous issues.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the macOS build configuration in the GitHub Actions workflow. It removes specific CMake MinSizeRel flags, adjusts comment and step naming for consistent capitalization of "macOS", and expands the binary renaming step by adding commands to print version information post-renaming. Additionally, a test workflow file is deleted, which previously facilitated the testing of static binaries across multiple environments. The README file is updated to reflect improved compatibility for the clang-tidy tool on macOS 64.

Changes

File Path	Change Summary
.github/workflows/build.yml	Removed -DCMAKE_CXX_FLAGS_MINSIZEREL="-Os" and -DCMAKE_C_FLAGS_MINSIZEREL="-Os" flags for macOS; standardized capitalization of "macOS" in comments and step names; added commands to print binary versions after renaming.
.github/workflows/test.yml	Deleted the workflow for testing static binaries across multiple OS and Clang versions.
README.md	Updated compatibility table for clang-tidy on macOS 64 to indicate support for versions 19 and 20; removed cautionary note about file sizes exceeding 2GB.

Possibly related PRs

• Update build.yml to fix macOs build #46: The changes in the main PR are directly related to those in the retrieved PR, as both involve modifications to the same sections of the .github/workflows/build.yml file, including the removal of specific CMake flags and updates to comments and version checks.
• Support clang tools version 20 #44: The changes in the main PR regarding the build configuration for macOS are related to the modifications in the retrieved PR, which also involves updates to the build workflow, specifically the inclusion of clang version 20.

Poem

I'm a rabbit with a hop in my stride,
Celebrating build tweaks far and wide.
Flags removed, the scripts now gleam,
With version checks that truly beam.
Hop along, dear code, let our builds abide!
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbe9314 and b29aee9.

📒 Files selected for processing (2)

• .github/workflows/test.yml (0 hunks)
• README.md (1 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/build.yml (2)

141-147: Consistent macOS Naming in Patch Step
The step name now reads “patch cmake implicit link libraries on macOS” with the proper capitalization, which improves readability. Note that the conditional still checks matrix.os == 'macosx' because that is the value defined in the matrix; this is acceptable as long as the displayed names follow the desired format.

---

161-172: Enhanced Binary Version Verification
Adding the version check commands after renaming the output binaries is a solid improvement. These commands help verify that the binaries are not only renamed correctly but are executable and report their version as expected. For extra robustness, consider incorporating error handling in case any of these binaries fail to return a version (for example, by checking the exit status and logging a clear error message).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between badb9e5 and dbe9314.

📒 Files selected for processing (1)

• .github/workflows/build.yml (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: build (9, linux)
• GitHub Check: build (14, macosx)
• GitHub Check: build (11, linux)
• GitHub Check: build (10, linux)
• GitHub Check: build (13, macosx)
• GitHub Check: build (12.0.1, macosx)
• GitHub Check: build (14, linux)
• GitHub Check: build (13, linux)
• GitHub Check: build (16, linux)
• GitHub Check: build (16, windows)
• GitHub Check: build (17, linux)
• GitHub Check: build (15, windows)
• GitHub Check: build (15, macosx)
• GitHub Check: build (18, windows)
• GitHub Check: build (20, linux)
• GitHub Check: build (20, windows)
• GitHub Check: build (19, windows)
• GitHub Check: build (19, linux)
• GitHub Check: build (20, macosx)
• GitHub Check: build (18, linux)

🔇 Additional comments (1)

.github/workflows/build.yml (1)

97-98: Clarify Download Patches Comments
The updated comments now clearly explain why a tarball is downloaded instead of relying on the local .git directory, thereby preventing any inadvertent leakage of the commit hash into the binaries.