Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 6, 2024

Bump cpp-linter/clang-tools-static-binaries to master-2e4f8c1f

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 6, 2024
@shenxianpeng
Copy link
Collaborator

Supersedes #99

@shenxianpeng shenxianpeng marked this pull request as draft June 6, 2024 16:18
@codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.12%. Comparing base (8d5f32b) to head (8e4b778).

Additional details and impacted files
@@ Coverage Diff @@ ## main #100 +/- ## ======================================= Coverage 96.12% 96.12% ======================================= Files 7 7 Lines 284 284 ======================================= Hits 273 273 Misses 11 11 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenxianpeng shenxianpeng marked this pull request as ready for review June 6, 2024 16:28
@shenxianpeng shenxianpeng requested a review from 2bndy5 June 6, 2024 16:28
@shenxianpeng shenxianpeng added the minor A minor version bump label Jun 6, 2024
@2bndy5
Copy link
Contributor

2bndy5 commented Jun 6, 2024

We should also update the readme about Mac os seg faults because that is now resolved.

@github-actions github-actions bot force-pushed the bump-clang-tools-static-binaries-version branch from 66a7fbc to bdc7d4a Compare June 7, 2024 01:25
Copy link
Contributor

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened?

I see there's a force-pushed commit, but the unit test's SHA files are no longer updated. Are you using a new IDE?

We still need to update the README too.

@shenxianpeng
Copy link
Collaborator

It must be because this runs https://github.com/cpp-linter/clang-tools-pip/actions/runs/9410179406/job/25921387400, I will make change it and not allow force push.

Pushing pull request branch to 'origin/bump-clang-tools-static-binaries-version' /usr/bin/git push --force-with-lease origin bump-clang-tools-static-binaries-version:refs/heads/bump-clang-tools-static-binaries-version To https://github.com/cpp-linter/clang-tools-pip + 66a7fbc...bdc7d4a bump-clang-tools-static-binaries-version -> bump-clang-tools-static-binaries-version (forced update) 
@shenxianpeng
Copy link
Collaborator

I didn't find any inputs that can suppress force push, so I removed the schedule from bump-version.yml 026c134

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

@shenxianpeng
Copy link
Collaborator

We should also update the readme about Mac os seg faults because that is now resolved.

We don't mention Mac os seg faults in clang-tools-pip (I have mentioned them in clang-tools-static-binaries but it was removed yesterday)

@shenxianpeng shenxianpeng requested a review from 2bndy5 June 7, 2024 03:50
Copy link
Contributor

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I was confusing the repo READMEs. 🤦‍♂️

@shenxianpeng shenxianpeng merged commit 7d78b27 into main Jun 7, 2024
@shenxianpeng shenxianpeng deleted the bump-clang-tools-static-binaries-version branch June 7, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file minor A minor version bump

3 participants