Skip to content

Disable hanging tests #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Disable hanging tests #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/coverlet.core.tests/Coverage/CoverageTests.DoesNotReturn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public void NoBranches_DoesNotReturnAttribute_InstrumentsCorrect()
}
}

[Fact]
[Fact(Skip = "Hang due to System.Console.ReadKey()")]
public void If_DoesNotReturnAttribute_InstrumentsCorrect()
{
string path = Path.GetTempFileName();
Expand Down Expand Up @@ -73,7 +73,7 @@ public void If_DoesNotReturnAttribute_InstrumentsCorrect()
}
}

[Fact]
[Fact(Skip = "Hang due to System.Console.ReadKey()")]
public void Switch_DoesNotReturnAttribute_InstrumentsCorrect()
{
string path = Path.GetTempFileName();
Expand Down Expand Up @@ -105,7 +105,7 @@ public void Switch_DoesNotReturnAttribute_InstrumentsCorrect()
}
}

[Fact]
[Fact(Skip = "Hang due to System.Console.ReadKey()")]
public void Subtle_DoesNotReturnAttribute_InstrumentsCorrect()
{
string path = Path.GetTempFileName();
Expand Down Expand Up @@ -137,7 +137,7 @@ public void Subtle_DoesNotReturnAttribute_InstrumentsCorrect()
}
}

[Fact]
[Fact(Skip = "Hang due to System.Console.ReadKey()")]
public void UnreachableBranch_DoesNotReturnAttribute_InstrumentsCorrect()
{
string path = Path.GetTempFileName();
Expand Down
8 changes: 8 additions & 0 deletions test/coverlet.core.tests/Instrumentation/ModuleTrackerTemplateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -62,14 +63,21 @@ public void HitsOnMultipleThreadsCorrectlyCounted()
{
FunctionExecutor.Run(() =>
{
List<Thread> threads = new List<Thread>();
using var ctx = new TrackerContext();
ModuleTrackerTemplate.HitsArray = new[] { 0, 0, 0, 0 };
for (int i = 0; i < ModuleTrackerTemplate.HitsArray.Length; ++i)
{
var t = new Thread(HitIndex);
threads.Add(t);
t.Start(i);
}

foreach (Thread t in threads)
{
t.Join();
}

ModuleTrackerTemplate.UnloadModule(null, null);
var expectedHitsArray = new[] { 4, 3, 2, 1 };
Assert.Equal(expectedHitsArray, ReadHitsFile());
Expand Down