Avoid to instrument compiler generated code when generated from excluded methods #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MarcoRossignoli added bug 
| /azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
| Some test fail, they seems a bit flaky, one time fails on debug and other time on release, maybe we should try to find something more stable. |
matteoerigozzi changed the title 
| Fix #670 |
matteoerigozzi changed the title | /azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
| @matteoerigozzi I did some small updates+add documentation can you take a look? |
| No pipelines are associated with this pull request. |
| /azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #129
Fix #670
Change instrumenter to keeping track of methods with ExcludeFromCodeCoverage attribute and exclude compiler-generated code for lamda, yield, async/await and local functions.
Check here
https://github.com/dotnet/roslyn/blob/1fcbc51/src/Compilers/CSharp/Portable/Symbols/Synthesized/GeneratedNames.cs
for compiler synthesized names.