Rework build definition #1524
Closed
Rework build definition #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lg2de force-pushed the more-simple-build branch 5 times, most recently from d9535e6 to 800710b Compare lg2de force-pushed the more-simple-build branch 5 times, most recently from 18d4fbb to 7c145b6 Compare lg2de force-pushed the more-simple-build branch from 7c145b6 to 8f8b14f Compare * remove SDKs not used in the projects * remove duplicated code
…debugging purposes
…n non-english systems
lg2de force-pushed the more-simple-build branch from 8f8b14f to 49cc7fd Compare Contributor Author
| @daveMueller , @MarcoRossignoli , please note that this fixes EXECUTING of some integration tests. |
Collaborator
| This PR was closed because it is outdated. |
Contributor Author
| What means outdated? |
Collaborator
| Sorry, the sequence of PRs are random but this PR was not rebased and is somehow obsolete. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Makes build definition less complex, hopefully...
The old SDKs (3.1, 5.0) are not used anymore.
The solution is using netstandard, net4xx, and net6.0, so SDK 6.0 is required for build. When global.json is used, we should install the version specified there.
Further, net7 is used explicitly in the integration tests and must be installed separately. Please note that currently only 7.0.203 is working fine. Newer versions causes compiler warnings/errors. This should be fixed separately.
Triggered and scheduled builds were using less shared definition than possible. This causes broken nightly build in the past.
The tests for MVCRAZOR and ASPNET were not executed on build server because of the wrong project settings. I fixed that and activated option to fail if this happens again.