Skip to content

Instrument class constructors #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2018
Merged

Instrument class constructors #147

merged 1 commit into from
Jul 14, 2018

Conversation

@latop2604
Copy link
Contributor

@latop2604 latop2604 commented Jul 11, 2018

Fix #142

Before :
image

After :
image

Code review is hightly required because I juste copy past the foreach loop without any other understanding.
@latop2604
Copy link
Contributor Author

latop2604 commented Jul 11, 2018

Bonus : coverage % increased

Before

Module Line Branch Method
coverlet.core 90,3% 86,6% 92,6%
coverlet.tracker 0% 0% 0%

After

Module Line Branch Method
coverlet.core 90,6% 85,9% 93,2%
coverlet.tracker 0% 0% 0%
@latop2604 latop2604 force-pushed the feature/ctor-coverage branch from dc58377 to 0cd2da0 Compare July 11, 2018 21:59
tonerdo
tonerdo approved these changes Jul 14, 2018
View reviewed changes
Copy link
Collaborator

@tonerdo tonerdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@tonerdo tonerdo merged commit abd4ae0 into coverlet-coverage:master Jul 14, 2018
NorekZ pushed a commit to NorekZ/coverlet that referenced this pull request Nov 8, 2018
@tonerdo
Merge pull request coverlet-coverage#147 from latop2604/feature/ctor-…
1ea100a 
…coverage Instrument class constructors
Elanis pushed a commit to Elanis/portfolio that referenced this pull request Dec 13, 2022
Bump coverlet.collector from 3.0.3 to 3.1.0 (#11)
0018792 
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.3 to 3.1.0. <details> <summary>Release notes</summary> *Sourced from [coverlet.collector's releases](https://github.com/coverlet-coverage/coverlet/releases).* > ## v3.1.0 > * 141 adds performance improvements to coverage tracker for multi-threaded scenarios > * a189fc26ea35b8ad77bd3be2bceac5c2996149a8 replaces Jil with JSON.NET for JSON serialization > * [#147](coverlet-coverage/coverlet#147) adds support for instrumenting constructors > * 4efea75e7c92e01652eb6c1c465ae1bcf9e56e6b ensures output filenames have extensions if non is specified > * [#154](coverlet-coverage/coverlet#154) makes enumeration based MSBuild properties case insensitive > * [#164](coverlet-coverage/coverlet#164) adds support for specifying include filters > * [#169](coverlet-coverage/coverlet#169) adds slight improvement for coverage tracking performance </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/coverlet-coverage/coverlet/commits/v3.1.0) </details> <br /> Reviewed-on: https://gitea.dysnomia.studio/elanis/portfolio/pulls/11 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Elanis pushed a commit to Elanis/portfolio that referenced this pull request Dec 13, 2022
Bump coverlet.msbuild from 3.0.3 to 3.1.0 (#7)
ec92a73 
Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 3.0.3 to 3.1.0. <details> <summary>Release notes</summary> *Sourced from [coverlet.msbuild's releases](https://github.com/coverlet-coverage/coverlet/releases).* > ## v3.1.0 > * 141 adds performance improvements to coverage tracker for multi-threaded scenarios > * a189fc26ea35b8ad77bd3be2bceac5c2996149a8 replaces Jil with JSON.NET for JSON serialization > * [#147](coverlet-coverage/coverlet#147) adds support for instrumenting constructors > * 4efea75e7c92e01652eb6c1c465ae1bcf9e56e6b ensures output filenames have extensions if non is specified > * [#154](coverlet-coverage/coverlet#154) makes enumeration based MSBuild properties case insensitive > * [#164](coverlet-coverage/coverlet#164) adds support for specifying include filters > * [#169](coverlet-coverage/coverlet#169) adds slight improvement for coverage tracking performance </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/coverlet-coverage/coverlet/commits/v3.1.0) </details> <br /> Reviewed-on: https://gitea.dysnomia.studio/elanis/portfolio/pulls/7 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Elanis pushed a commit to Dysnomia-Studio/dehash-me that referenced this pull request Mar 12, 2023
Bump coverlet.collector from 3.0.3 to 3.1.0 (#17)
cadb48d 
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.3 to 3.1.0. <details> <summary>Release notes</summary> *Sourced from [coverlet.collector's releases](https://github.com/coverlet-coverage/coverlet/releases).* > ## v3.1.0 > * 141 adds performance improvements to coverage tracker for multi-threaded scenarios > * a189fc26ea35b8ad77bd3be2bceac5c2996149a8 replaces Jil with JSON.NET for JSON serialization > * [#147](coverlet-coverage/coverlet#147) adds support for instrumenting constructors > * 4efea75e7c92e01652eb6c1c465ae1bcf9e56e6b ensures output filenames have extensions if non is specified > * [#154](coverlet-coverage/coverlet#154) makes enumeration based MSBuild properties case insensitive > * [#164](coverlet-coverage/coverlet#164) adds support for specifying include filters > * [#169](coverlet-coverage/coverlet#169) adds slight improvement for coverage tracking performance </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/coverlet-coverage/coverlet/commits/v3.1.0) </details> <br /> Reviewed-on: https://gitea.dysnomia.studio/elanis/dehash-me/pulls/17 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Elanis pushed a commit to Dysnomia-Studio/dehash-me that referenced this pull request Mar 12, 2023
Bump coverlet.msbuild from 3.0.3 to 3.1.0 (#13)
f3de5a2 
Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 3.0.3 to 3.1.0. <details> <summary>Release notes</summary> *Sourced from [coverlet.msbuild's releases](https://github.com/coverlet-coverage/coverlet/releases).* > ## v3.1.0 > * 141 adds performance improvements to coverage tracker for multi-threaded scenarios > * a189fc26ea35b8ad77bd3be2bceac5c2996149a8 replaces Jil with JSON.NET for JSON serialization > * [#147](coverlet-coverage/coverlet#147) adds support for instrumenting constructors > * 4efea75e7c92e01652eb6c1c465ae1bcf9e56e6b ensures output filenames have extensions if non is specified > * [#154](coverlet-coverage/coverlet#154) makes enumeration based MSBuild properties case insensitive > * [#164](coverlet-coverage/coverlet#164) adds support for specifying include filters > * [#169](coverlet-coverage/coverlet#169) adds slight improvement for coverage tracking performance </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/coverlet-coverage/coverlet/commits/v3.1.0) </details> <br /> Reviewed-on: https://gitea.dysnomia.studio/elanis/dehash-me/pulls/13 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Elanis pushed a commit to Dysnomia-Studio/dysnomia-website that referenced this pull request Jul 14, 2023
Bump coverlet.collector from 3.0.3 to 3.1.0 (#14)
b984246 
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.0.3 to 3.1.0. <details> <summary>Release notes</summary> *Sourced from [coverlet.collector's releases](https://github.com/coverlet-coverage/coverlet/releases).* > ## v3.1.0 > * 141 adds performance improvements to coverage tracker for multi-threaded scenarios > * a189fc26ea35b8ad77bd3be2bceac5c2996149a8 replaces Jil with JSON.NET for JSON serialization > * [#147](coverlet-coverage/coverlet#147) adds support for instrumenting constructors > * 4efea75e7c92e01652eb6c1c465ae1bcf9e56e6b ensures output filenames have extensions if non is specified > * [#154](coverlet-coverage/coverlet#154) makes enumeration based MSBuild properties case insensitive > * [#164](coverlet-coverage/coverlet#164) adds support for specifying include filters > * [#169](coverlet-coverage/coverlet#169) adds slight improvement for coverage tracking performance </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/coverlet-coverage/coverlet/commits/v3.1.0) </details> <br /> Reviewed-on: https://gitea.dysnomia.studio/elanis/dysnomia-website/pulls/14 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Elanis added a commit to Dysnomia-Studio/dysnomia-website that referenced this pull request Jul 14, 2023
@Elanis
Bump coverlet.msbuild from 3.0.3 to 3.1.0 (#10)
9c3160b 
Bumps [coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from 3.0.3 to 3.1.0. <details> <summary>Release notes</summary> *Sourced from [coverlet.msbuild's releases](https://github.com/coverlet-coverage/coverlet/releases).* > ## v3.1.0 > * 141 adds performance improvements to coverage tracker for multi-threaded scenarios > * a189fc26ea35b8ad77bd3be2bceac5c2996149a8 replaces Jil with JSON.NET for JSON serialization > * [#147](coverlet-coverage/coverlet#147) adds support for instrumenting constructors > * 4efea75e7c92e01652eb6c1c465ae1bcf9e56e6b ensures output filenames have extensions if non is specified > * [#154](coverlet-coverage/coverlet#154) makes enumeration based MSBuild properties case insensitive > * [#164](coverlet-coverage/coverlet#164) adds support for specifying include filters > * [#169](coverlet-coverage/coverlet#169) adds slight improvement for coverage tracking performance </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/coverlet-coverage/coverlet/commits/v3.1.0) </details> <br /> Co-authored-by: Elanis <elanis@hotmail.com> Reviewed-on: https://gitea.dysnomia.studio/elanis/dysnomia-website/pulls/10 Co-authored-by: elanis <elanis@noreply.example.org> Co-committed-by: elanis <elanis@noreply.example.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@latop2604 @tonerdo