- Notifications
You must be signed in to change notification settings - Fork 604
Support different serving images on a per-API basis #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different serving images on a per-API basis #948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RobertLucian wow, amazing job on this!! I can see the effort you put in to match our conventions and find all code that should be updated, thank you for your attention to detail!
I reviewed all but the docker image accessibility check; I'll check that out soon. The main comment is that Vishal and I spoke, and we think it probably makes sense to remove the "user-facing" images from cluster configuration now that we have it in the API configuration, what do you think? I'd be happy to discuss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@RobertLucian Thanks again for your great work on this! |
Closes #900, #950.
This PR includes support for public-accessible docker images (i.e. DockerHub) and ECR images under the cluster's AWS credentials.
Here is a set of errors that could possibly be returned by this new feature:
checklist:
make test
andmake lint
summary.md
(view in gitbook after merging)