Custom autoscaler #815
Merged
Custom autoscaler #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… custom-autoscaler
… custom-autoscaler
… custom-autoscaler
vishalbollu approved these changes Feb 14, 2020
pkg/operator/operator/autoscaler.go Outdated
| } | ||
| | ||
| if len(output.MetricDataResults[0].Timestamps) == 0 { | ||
| return nil, nil |
There was a problem hiding this comment.
maybe return error here instead of nil, like metrics are not available yet?
There was a problem hiding this comment.
That is the message that is shown when nil is returned, is that ok? Or did you intend to explicitly return an error?
| } | ||
| | ||
| if timestampCounter == -1 { | ||
| return nil, nil // no metrics were available in the last 2 tick intervals |
There was a problem hiding this comment.
maybe return err here indicating metrics were not found?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
closes #573
checklist:
make testandmake lintsummary.md(view in gitbook after merging)