Ensure previous logs are never shown after showing newer ones #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vishalbollu reviewed Feb 11, 2020
pkg/operator/operator/logs.go Outdated
| | ||
| endTime := libtime.ToMillis(time.Now()) | ||
| | ||
| if lastLogTime.Before(lastLogTimeQuery) { |
There was a problem hiding this comment.
I think this if statement can be removed if this line was deleted https://github.com/cortexlabs/cortex/pull/792/files#diff-0751bf49752315b9e28b82c491299692R162 and the poll period was subtracted here https://github.com/cortexlabs/cortex/pull/792/files#diff-0751bf49752315b9e28b82c491299692R162
vishalbollu approved these changes Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
make testandmake lint