Skip to content

Remove extra parameters that may be sent JSON tricks encoder initialization #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2019
Merged

Remove extra parameters that may be sent JSON tricks encoder initialization #565

merged 1 commit into from
Nov 8, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Nov 8, 2019 •
edited
Loading

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged
@vishalbollu vishalbollu requested a review from deliahu November 8, 2019 14:08
@vishalbollu vishalbollu merged commit 21f7ee4 into master Nov 8, 2019
@vishalbollu vishalbollu deleted the remove-extra-params-json-tricks-encoder branch November 8, 2019 17:01
deliahu pushed a commit that referenced this pull request Nov 8, 2019
@vishalbollu @deliahu
Remove extra parameters that may be sent JSON tricks encoder initiali…
6ab748b 
…zation (#565) (cherry picked from commit 21f7ee4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@vishalbollu @deliahu