Skip to content

Fix Grafana dashboard for AsyncAPIs #2444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Grafana dashboard for AsyncAPIs #2444

wants to merge 2 commits into from

Conversation

jackmpcollins
Copy link
Contributor

Changes

  • Fix typo: async_queue_length -> async_queued so that the list of api_names is populated (currently empty)
  • Use =~ with api_name where missing to enable displaying multiple AsyncAPIs on a panel
  • For the "In-Flight Requests" panel include the api_name in the legend

Testing

I have made the corresponding updates manually through the Grafana UI for our deployed Cortex cluster. AsyncAPIs now list in the "Cortex / AsyncAPI" dashboard and the dashboard works when multiple AsyncAPIs are selected.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@jackmpcollins