Add shell instruction to serving Dockerfiles #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
deliahu reviewed Jun 2, 2020
deliahu approved these changes Jun 2, 2020
| Looks great, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Coming as an improvement to #1086 (comment). Closes #1086.
Instead of having to run
RUN /bin/bash -c "pip install ..."for a custom image based on any of Cortex's base serving images or insidedependencies.sh, the user now only has to addRUN pip install ....Also, clarify the docs about pip/conda installations for extended Dockerfiles.
checklist:
make testandmake lintsummary.md(view in gitbook after merging)