Skip to content

Conversation

dsuess
Copy link
Contributor

@dsuess dsuess commented Jun 1, 2020

closes #1100

Couldn't test locally since it requires re-building the Docker images.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • (N/A) update examples
  • (N/A) update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • (N/A) alert the dev team if the dev environment changed
@CLAassistant
Copy link

CLAassistant commented Jun 1, 2020

CLA assistant check
All committers have signed the CLA.

@RobertLucian RobertLucian added the bug Something isn't working label Jun 1, 2020
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works! Great catch @dsuess!

@deliahu deliahu merged commit 804f0bf into cortexlabs:master Jun 1, 2020
deliahu pushed a commit that referenced this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

4 participants