Skip to content

Skip environment provider prompt if name is known #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2020
Merged

Skip environment provider prompt if name is known #1045

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8c9e19
Skip environment provider prompt if name is known
deliahu May 8, 2020
fa0d4de
Merge branch 'master' into skip-provider-prompt
deliahu May 8, 2020
8929d5a
Merge branch 'master' into skip-provider-prompt
deliahu May 9, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions cli/cmd/lib_cli_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ func promptExistingEnvName(promptMsg string) string {
exit.Error(err)
}

fmt.Printf("currently configured environments: %s\n\n", strings.Join(configuredEnvNames, ", "))
fmt.Printf("your currently configured environments are: %s\n\n", strings.Join(configuredEnvNames, ", "))

envNameContainer := &struct {
EnvironmentName string
Expand Down Expand Up @@ -266,7 +266,7 @@ func promptAWSEnvName() string {
envNamesSet := strset.New(configuredEnvNames...)
envNamesSet.Remove("local")
if len(envNamesSet) > 0 {
fmt.Printf("currently configured AWS environments: %s\n\n", strings.Join(envNamesSet.Slice(), ", "))
fmt.Printf("your currently configured AWS environments are: %s\n\n", strings.Join(envNamesSet.Slice(), ", "))
}

envNameContainer := &struct {
Expand Down Expand Up @@ -294,6 +294,16 @@ func promptAWSEnvName() string {
}

func promptProvider(env *cliconfig.Environment) error {
if env.Name != "" {
if env.Name == types.LocalProviderType.String() {
env.Provider = types.LocalProviderType
} else {
env.Provider = types.AWSProviderType
}
fmt.Printf("provider: %s\n\n", env.Provider)
return nil
}

return cr.ReadPrompt(env, &cr.PromptValidation{
SkipNonEmptyFields: true,
PromptItemValidations: []*cr.PromptItemValidation{
Expand Down