Skip to content

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Feb 22, 2024

yarn outdated output after this PR:

Package Current Wanted Latest Workspace Package Type URL @types/node 18.19.17 18.19.17 20.11.19 @commitlint/cli devDependencies https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node @types/node 18.19.17 18.19.17 20.11.19 @commitlint/load devDependencies https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node cosmiconfig 8.3.6 8.3.6 9.0.0 @commitlint/load dependencies https://github.com/cosmiconfig/cosmiconfig#readme glob 8.1.0 8.1.0 10.3.10 @commitlint/config-lerna-scopes dependencies https://github.com/isaacs/node-glob#readme glob 8.1.0 8.1.0 10.3.10 @commitlint/config-patternplate dependencies https://github.com/isaacs/node-glob#readme glob 8.1.0 8.1.0 10.3.10 @commitlint/ensure devDependencies https://github.com/isaacs/node-glob#readme glob 8.1.0 8.1.0 10.3.10 @commitlint/rules devDependencies https://github.com/isaacs/node-glob#readme lerna 6.4.1 6.6.2 8.1.2 @commitlint/root devDependencies https://lerna.js.org prettier 2.8.8 2.8.8 3.2.5 @commitlint/root devDependencies https://prettier.io 

I'll continue upgrading above packages in another PR.


Question: Should we upgrade @types/node to latest version or stick on v18?

@escapedcat
Copy link
Member

Question: Should we upgrade @types/node to latest version or stick on v18?

My current handling is that we use teh types for the lowest supported version (v18). Does this make sense?

Thanks for you work!
We do not need to update all deps everything before doing a release. Let me know when you think we're far enough.

@escapedcat escapedcat merged commit b7254bf into conventional-changelog:master Feb 22, 2024
@JounQin
Copy link
Collaborator Author

JounQin commented Feb 22, 2024

My current handling is that we use teh types for the lowest supported version (v18). Does this make sense?

Sure!

We do not need to update all deps everything before doing a release. Let me know when you think we're far enough.

In case we're doing a major release, so I think it's a good time to upgrade dependencies.

I'm holding on cosmiconfig because it changes its config search strategy on v9: https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#900

glob is rewritten and some internal things changed, although the functionality is not affected anyway.

What do you think about these remaining dependencies?

@escapedcat

@JounQin JounQin deleted the feat/esm branch February 22, 2024 15:10
@escapedcat
Copy link
Member

I'm good with the current state. Rather release sooner than later to unblock waiting PRs. wdyt?

@JounQin
Copy link
Collaborator Author

JounQin commented Feb 22, 2024

I'd like to wait for a while for cosmiconfig/cosmiconfig#339 and upgrade glob shortly.

AFAIK, we're not in an emergency situation, right?

@escapedcat
Copy link
Member

AFAIK, we're not in an emergency situation, right?

:D No, none of this is an emergency 🙌

I'd like to wait for a while for cosmiconfig/cosmiconfig#339 and upgrade glob shortly.

Sure, go ahead.
Might be good to wait with upgrading lerna/prettier. Had some related issue in the past which was only blocking publishing a release. Which was annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants