Skip to content

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 7, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
node docker major 14 -> 16
node docker major 12 -> 16
node docker major 10 -> 16

Release Notes

nodejs/node

v16

Moved to doc/changelogs/CHANGELOG_V012.md#​0.12.14.

v15

Moved to doc/changelogs/CHANGELOG_V4.md#​4.2.4.


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@escapedcat
Copy link
Member

Hey @AdeAttwood , the renovate-bot PR for node v16 just arrived.
I thought it might be a good chance to get rid of v10 support. What do you think?
I would move the "required" circle-ci check from v10 to v16 as well.

@AdeAttwood
Copy link
Member

@escapedcat this looks good to me.

I see your commit and this should sort out #2578 👍

renovate-bot and others added 2 commits May 12, 2021 16:16
add node 16 to circleci checks BREAKING CHANGE: minimum node version is 12
@escapedcat escapedcat force-pushed the renovate/node-16.x branch from 655beac to 2a4cec5 Compare May 12, 2021 08:19
@escapedcat escapedcat merged commit d392de1 into master May 12, 2021
@escapedcat escapedcat deleted the renovate/node-16.x branch May 12, 2021 08:26
@JounQin
Copy link
Collaborator

JounQin commented May 13, 2021

Is this a BREAKING CHANGE actually?

@escapedcat
Copy link
Member

@JounQin yes, the breaking change is indicated with this commit:
image
2a4cec5

@JounQin
Copy link
Collaborator

JounQin commented May 13, 2021

image

@escapedcat I was reading commits history, and your mentioned commit is squashed into one single commit with the previous one. 🤣

@escapedcat
Copy link
Member

escapedcat commented May 13, 2021

Ah nice, yes! I didn't think about this when merging. Thanks, will fix!

@escapedcat
Copy link
Member

Hm, the breaking change is still being indicated by the merge commit: d392de1

BREAKING CHANGE: minimum node version is 12

So 13.0.0 will be created.
You think the type/subject should be adjusted?

@JounQin
Copy link
Collaborator

JounQin commented May 13, 2021

the breaking change is still being indicated by the merge commit

That is nice, I was just concerning about #2574 and #2575, and then I found this PR at the same time.

escapedcat added a commit that referenced this pull request May 13, 2021
- #2574 - #2575 - #2582 BREAKING CHANGE: minimum node version is 12
escapedcat added a commit that referenced this pull request May 13, 2021
- #2574 - #2575 - #2582 BREAKING CHANGE: minimum node version is 12
sheerlox pushed a commit to insurgent-lab/commitlint-config that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants