- Notifications
You must be signed in to change notification settings - Fork 3.9k
Add ACP server support to CLI #9222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
1 similar comment
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
| All contributors have signed the CLA ✍️ ✅ |
Documentation Enhancement SuggestionI've reviewed the ACP documentation added in this PR and created some enhancements using Mintlify components to improve readability and user experience. Since this is from a fork, I can't create a PR directly against your branch. Here's a summary of the suggested improvements to Changes Made
Why These Enhancements?The original documentation is comprehensive and clear! These changes simply leverage Mintlify's UI components to:
View the ChangesYou can see the enhanced version on my branch: docs/acp-documentation-enhancements Or view the diff here: pr-9222...docs/acp-documentation-enhancements Feel free to cherry-pick the commit if you'd like to include these enhancements: git fetch origin docs/acp-documentation-enhancements git cherry-pick da9779b4eLet me know if you'd like me to make any adjustments or if you'd prefer a different approach! |
| I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 12 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. <file name="extensions/cli/src/commands/acp.ts"> <violation number="1" location="extensions/cli/src/commands/acp.ts:17"> P2: Using `process.exit(1)` directly bypasses telemetry and Sentry flushing. Consider using `gracefulExit(1)` from `../util/exit.js` to ensure error tracking data is not lost, consistent with other commands like `login.ts` and `remote-test.ts`.</violation> </file> Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| } catch (error) { | ||
| const message = error instanceof Error ? error.message : String(error); | ||
| safeStderr(`ACP server failed: ${message}\n`); | ||
| process.exit(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Using process.exit(1) directly bypasses telemetry and Sentry flushing. Consider using gracefulExit(1) from ../util/exit.js to ensure error tracking data is not lost, consistent with other commands like login.ts and remote-test.ts.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/cli/src/commands/acp.ts, line 17: <comment>Using `process.exit(1)` directly bypasses telemetry and Sentry flushing. Consider using `gracefulExit(1)` from `../util/exit.js` to ensure error tracking data is not lost, consistent with other commands like `login.ts` and `remote-test.ts`.</comment> <file context> @@ -0,0 +1,19 @@ + } catch (error) { + const message = error instanceof Error ? error.message : String(error); + safeStderr(`ACP server failed: ${message}\n`); + process.exit(1); + } +} </file context> Update: Code Review Fix AppliedI've also addressed the code review feedback from cubic regarding the Issue Fixed
This ensures:
The fix has been pushed to my branch alongside the documentation enhancements. You can cherry-pick both commits: git fetch origin docs/acp-documentation-enhancements git cherry-pick da9779b4e # Documentation enhancements git cherry-pick 5fa179cbb # gracefulExit fixOr merge the entire branch if you prefer! |

Adds an ACP stdio server command to the Continue CLI, including prompt/tool mapping utilities and docs for Zed ACP setup.
Summary by cubic
Add an ACP stdio server to the Continue CLI so Zed and other ACP editors can use Continue for streaming chat and tool execution. Introduces a hidden cn acp subcommand, prompt/tool mapping utilities, and setup docs.
New Features
Migration
Written for commit e39c881. Summary will update automatically on new commits.