feat: improve podman cli execution for models #1810
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
axel7083 force-pushed the refactor/move-model-utils-logic-podman branch from 6ee9c3b to 963bad8 Compare 1 task
Contributor Author
| Need rebase when the following will be merged |
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083 force-pushed the refactor/move-model-utils-logic-podman branch from 963bad8 to 1f0b6f5 Compare axel7083 changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following #1813 the
isModelUploadedanddeleteRemoteModelare moved inside theModelManagerclass, and uses thePodmanConnection,executeSSHmethod.Screenshot / video of UI
What issues does this PR fix or reference?
Fixes #1809
How to test this PR?