shim: add log after shim shutdown #12456
Open
+3 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fuweid reviewed Nov 7, 2025
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
ningmingxiao force-pushed the log_after_shutdown branch 2 times, most recently from 0eddc11 to bd72e9d Compare ningmingxiao force-pushed the log_after_shutdown branch 2 times, most recently from 14296e6 to 0eddc11 Compare Contributor Author
| do we need call sd.Shutdown() at start and delete stage? it should be a bug old version always call sd.Shutdown() at start and delete and default stage. @fuweid |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
because of #12344 this issue, containerd failed to shutdown shim(shim doesn't call shutdown func). so it is necessary to check shim shutdown is called. @fuweid