Skip to content

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented Feb 13, 2019

Minor code style fixes done with help of php-cs-fixer.

Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is this related any of existing issues?
  2. Does the PHP_CodeSniffer check (see CONTRIBUTING.md) now pass?
@glensc
Copy link
Contributor Author

glensc commented Feb 13, 2019

  1. not directly. i was about to make changes, but noticed is_null in place
  2. i don't use the tool. shouldn't travis complain on this?
@aik099
Copy link
Member

aik099 commented Feb 13, 2019

  1. not directly. i was about to make changes, but noticed is_null in place

I see.

  1. i don't use the tool. shouldn't travis complain on this?

It's not doing that currently. It makes sense to do only, when we fix all existing issues to avoid all new build be broken by default.

@glensc
Copy link
Contributor Author

glensc commented Feb 13, 2019

checked vendor/bin/phpcs, the changes here are not related.

@aik099
Copy link
Member

aik099 commented Feb 14, 2019

Maybe can combine all CS fixes into single PR? I've just updated composer.json and composer.lock to ensure that used CS is compatible with latest PHP_CodeSniffer version.

PHP_CodeSniffer also does support auto-fixing of most, but not all issues found.

If you're using PhpStorm, then you configure it to automatically highlight problematic places.

We're not using Scrutinizer CI or otherwise it will be showing CS issues online as well.

@glensc
Copy link
Contributor Author

glensc commented Feb 14, 2019

You can squash merge from GitHub web UI if you have enabled that in project. If that's what you mean by single commit.

@glensc
Copy link
Contributor Author

glensc commented Feb 14, 2019

At this moment, I do not plan to make more CS fixes.

Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no more CS fixes are planned, then please adjust your fixes to match existing coding standard.

@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.18%. Comparing base (3958a27) to head (8833122).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Jira/Api.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #184 +/- ## ========================================= Coverage 62.18% 62.18% Complexity 205 205 ========================================= Files 10 10 Lines 669 669 ========================================= Hits 416 416 Misses 253 253 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099
Copy link
Member

aik099 commented Dec 27, 2024

Merging, thanks @glensc .

@aik099 aik099 merged commit afa00f5 into console-helpers:master Dec 27, 2024
12 checks passed
@glensc glensc deleted the codestyle branch December 28, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants