Skip to content

Conversation

MSeal
Copy link
Contributor

@MSeal MSeal commented Oct 2, 2025

Fixes issues discovered during building the 2.12.0b1 release for tag build paths.

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

@MSeal MSeal requested review from a team as code owners October 2, 2025 06:16
@Copilot Copilot AI review requested due to automatic review settings October 2, 2025 06:16
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to be a temporary build configuration change to force artifact generation for version v2.12.0b1, bypassing the normal tag-based build triggers. The title explicitly states "DO NOT MERGE" indicating this is for testing purposes only.

  • Removes tag-based build conditions from all wheel building jobs
  • Hardcodes version string v2.12.0b1-dev1 in packaging commands
  • Adds changelog entry for v2.12.0b1 release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
CHANGELOG.md Adds new version entry for v2.12.0b1
.semaphore/semaphore.yml Removes tag conditions and hardcodes version strings for artifact building

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 383 to 387
- tar cvf confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz wheelhouse/
- ls -la
- sha256sum confluent-kafka-python-wheels-${SEMAPHORE_GIT_TAG_NAME}-${SEMAPHORE_WORKFLOW_ID}.tgz
- sha256sum confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz
- cd ..
- artifact push project artifacts/confluent-kafka-python-wheels-${SEMAPHORE_GIT_TAG_NAME}-${SEMAPHORE_WORKFLOW_ID}.tgz --destination confluent-kafka-python-wheels-${SEMAPHORE_GIT_TAG_NAME}-${SEMAPHORE_WORKFLOW_ID}.tgz
- artifact push project artifacts/confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz --destination confluent-kafka-python-wheels-v2.12.0b1-dev1-${SEMAPHORE_WORKFLOW_ID}.tgz
Copy link

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded version string 'v2.12.0b1-dev1' creates maintenance burden and potential for inconsistency. Consider using a build parameter or environment variable instead of hardcoding the version in multiple places.

Copilot uses AI. Check for mistakes.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

1 similar comment
@sonarqube-confluent

This comment has been minimized.

@MSeal MSeal changed the title [DO NOT MERGE] V2.12.0b1 Forcing build for artifacts V2.12.0b1 Image Build Fixes Oct 2, 2025
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (66.90% Estimated after merge)
  • Duplications No duplication information (4.90% Estimated after merge)

Project ID: confluent-kafka-python

View in SonarQube

Copy link
Member

@k-raina k-raina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@MSeal MSeal merged commit 9304bd6 into master Oct 6, 2025
3 checks passed
@MSeal MSeal deleted the v2.12.0b1 branch October 6, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants