Skip to content

Setup isort and black library #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Setup isort and black library #1352

wants to merge 3 commits into from

Conversation

@jairhenrique
Copy link
Contributor

Fixes #1351
tidy up json serde (confluentinc#1340)
453a25d 
* tidy up json serde * to_dict doc tweaks * serializer text tweak * produces -> outputs * address review comments * minor tweak
@jairhenrique jairhenrique requested a review from a team as a code owner May 23, 2022 21:55
tidy up protobuf serde (confluentinc#1337)
b733b94 
* tidy up protobuf serde * tweak sr explanation text * tweak SerializeError text * changes following review of JSON Schema PR
@mhowlett
Copy link
Contributor

thanks @jairhenrique ! note that i'm currently working on a branch serdes to tidy a lot of stuff up. To avoid merge conflicts i think we'll do the code formatting after that gets merged to master.
@jairhenrique jairhenrique changed the base branch from master to serdes May 23, 2022 22:03
@jairhenrique jairhenrique force-pushed the lint branch 2 times, most recently from 7a3628b to e78b1cb Compare May 23, 2022 22:09
@jairhenrique
Copy link
Contributor Author

@mhowlett I move this changes to serdes branch and remove source formatting.
@edenhill
Copy link
Contributor

Nice 👍

We'll want this added as one of the build steps in .travis.yml too, replacing the flake8 with the lint check target.
Only need to do this for the Linux source builder.
@jairhenrique jairhenrique force-pushed the lint branch 3 times, most recently from 7e47ad3 to e014098 Compare May 24, 2022 11:37
@jairhenrique
Copy link
Contributor Author

@edenhill done!
@mhowlett mhowlett deleted the branch confluentinc:serdes September 14, 2022 21:45
@mhowlett mhowlett closed this Sep 14, 2022
@jairhenrique jairhenrique deleted the lint branch September 14, 2022 21:55
@palfrey
Copy link

palfrey commented Jan 5, 2023

@mhowlett What happened to this work? Not seeing it in master?
@palfrey palfrey mentioned this pull request Jan 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@jairhenrique @mhowlett @edenhill @palfrey