Fixed some testing docs and consume in DeserializingConsumer #1085
Conversation
- This commit still needs unit tests, as tox is not yet working on my machine.
| It looks like @Egg3141592654 hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
| @confluentinc It looks like @Egg3141592654 just signed our Contributor License Agreement. 👍 Always at your service, clabot |
| | ||
| for message in messages: | ||
| if message.error() is not None: | ||
| raise ConsumeError(message.error(), kafka_message=message) |
There was a problem hiding this comment.
this implementation effectively causes message without error to be thrown away, which is probably not ideal.
thanks for the PR, currently re-considering the need for batch consume.
There was a problem hiding this comment.
Good point, only did this to ensure that we kept parity with the singular API, but returning the messages with the error code is likely the better idea. I removed the exception throw.
| $ python3 -m venv venv_test | ||
| $ source venv_test/bin/activate | ||
| $ pip install -r test/requirements.txt | ||
| $ pip install -r tests/requirements.txt |
.gitignore Outdated
| .idea | ||
| tmp-KafkaCluster | ||
| .venv | ||
| venv_test/* |
There was a problem hiding this comment.
👍
but a newline would be nice.
There was a problem hiding this comment.
No need for *, the dir is sufficient.
| Nice I really hope this will be part of 1.8.0 👍 |
|
|
4 participants
This commit enables the consume method for the deserializing consumer. Encountering some issues running tests in WSL2, will create a VM and try to run tests fully there.