Add semaphore task to create tags #1492
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Semaphore CI task configuration for creating Git tags. The task allows manual triggering with a customizable tag name parameter, providing a standardized way to create and push tags to the repository.
Key Changes
- Added a new parameterized Semaphore task definition for Git tag creation
- Configured the task to run on the main branch with a required TAG_NAME parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| service.yml | Adds task configuration to enable the create-git-tag task with parameters |
| .semaphore/create-git-tag.yml | Defines the Semaphore pipeline for creating and pushing Git tags |
Comments suppressed due to low confidence (1)
.semaphore/create-git-tag.yml:1
- The git tag command lacks error handling for existing tags. If TAG_NAME already exists, the command will fail. Consider adding the
-fflag for force overwriting, or add a check to verify the tag doesn't exist, or usegit tag -a ${TAG_NAME} -m "Created tag ${TAG_NAME}"for annotated tags with proper error handling.
version: v1.0 💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| - name: Create Git Tag | ||
| commands: | ||
| - git tag ${TAG_NAME} |
There was a problem hiding this comment.
Creating a lightweight tag instead of an annotated tag. Annotated tags are recommended for releases as they store tagger information, date, and message. Consider using git tag -a ${TAG_NAME} -m \"Release ${TAG_NAME}\" instead.
| - git tag ${TAG_NAME} | |
| - git tag -a ${TAG_NAME} -m "Release ${TAG_NAME}" |
| - name: TAG_NAME | ||
| required: true | ||
| description: The name of the tag to be created. | ||
| default_value: "X.Y.Z" |
There was a problem hiding this comment.
The default value 'X.Y.Z' is a placeholder that could lead to accidental creation of invalid tags. Consider removing the default_value to force users to explicitly provide a tag name, or use a more descriptive placeholder like 'v0.0.0' that follows semantic versioning.
| default_value: "X.Y.Z" |
|
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups