Skip to content

Conversation

@emasab
Copy link
Contributor

@emasab emasab commented Oct 9, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

Copilot AI review requested due to automatic review settings October 9, 2025 08:53
@emasab emasab requested review from a team as code owners October 9, 2025 08:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the confluent-kafka-go library from release candidate v2.12.0-RC2 to the final stable release v2.12.0.

  • Updated Go module dependencies from v2.12.0-RC2 to v2.12.0
  • Updated documentation and build references to reflect the stable release
  • Updated CI configuration to use the stable librdkafka version

Reviewed Changes

Copilot reviewed 16 out of 24 changed files in this pull request and generated no comments.

Show a summary per file
File Description
soaktest/go.mod Updated dependency version from RC2 to stable
kafkatest/go.mod Updated dependency version from RC2 to stable
examples/go.mod Updated dependency version from RC2 to stable
examples/docker_aws_lambda_example/go.mod Updated dependency version from RC2 to stable
schemaregistry/api.html Updated GitHub links to point to stable v2.12.0
mk/doc-gen.py Updated tag variable from RC2 to stable version
kafka/generated_errors.go Updated generation comment to reflect stable librdkafka
kafka/build_*.go Updated librdkafka link info strings to stable version
README.md Updated minimum librdkafka version requirement
.semaphore/semaphore.yml Updated CI environment variable to stable version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent
Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (55.40% Estimated after merge)
  • Duplications No duplication information (1.30% Estimated after merge)

Project ID: confluent-kafka-go

View in SonarQube

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a question.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we support Windows now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already in previous versions

@emasab emasab merged commit 9a19915 into master Oct 9, 2025
2 of 3 checks passed
@emasab emasab deleted the import_v2.12.0 branch October 9, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants