- Notifications
You must be signed in to change notification settings - Fork 697
Import v2.11.0-RC3 #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import v2.11.0-RC3 #1450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the Confluent Kafka Go client and its underlying librdkafka dependency to v2.11.0-RC3, updates all related build constants, docs, and CI settings, and adds a new changelog entry for the release candidate.
- Updated dependency versions in go.mod files across modules, examples, and tests
- Regenerated API HTML and doc-gen script with the new tag and Go version
- Bumped librdkafka version macros, build info constants, CI env var, README, and CHANGELOG
Reviewed Changes
Copilot reviewed 19 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| soaktest/go.mod | Bump confluent-kafka-go dependency to v2.11.0-RC3 |
| kafkatest/go.mod | Bump confluent-kafka-go dependency to v2.11.0-RC3 |
| examples/*/go.mod (multiple) | Bump examples’ go.mod to v2.11.0-RC3 |
| mk/doc-gen.py | Update doc-gen tag to v2.11.0-RC3 |
| schemaregistry/api.html | Update links and Go version to reflect new tag |
| kafka/librdkafka_vendor/rdkafka.h | Bump RD_KAFKA_VERSION to 0x020b00ff |
| kafka/00version.go | Update MIN_RD_KAFKA_VERSION and error strings |
| kafka/build_*.go (multiple) | Update LibrdkafkaLinkInfo for various platforms |
| kafka/generated_errors.go | Regenerate errors for librdkafka v2.11.0-RC3 |
| README.md | Update supported librdkafka version text |
| CHANGELOG.md | Add v2.11.0 changelog section |
| .semaphore/semaphore.yml | Bump LIBRDKAFKA_VERSION env to v2.11.0-RC3 |
| // ErrTelemetryTooLarge Broker: Client sent a push telemetry request larger than the maximum size the broker will accept | ||
| ErrTelemetryTooLarge ErrorCode = C.RD_KAFKA_RESP_ERR_TELEMETRY_TOO_LARGE | ||
| // ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata. | ||
| // ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata |
Copilot AI Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is missing a period at the end to match the punctuation style of other error descriptions.
| // ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata | |
| // ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata. |
milindl left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Tested locally with integration and other tests too.
| I can reproduce the segfault in the tests however |
kafka/config_test.go Outdated
| // Best practice is to use dynamic linking if | ||
| // librdkafka plugins are used, | ||
| // as otherwise the statically linked version of librdkafka | ||
| // needs to correspond to the dinamically linked one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Just 'dynamically'
852980c to 0002f91 Compare 0002f91 to 7ff8d56 Compare
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups