Skip to content

Conversation

@emasab
Copy link
Contributor

@emasab emasab commented Jul 2, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

Copilot AI review requested due to automatic review settings July 2, 2025 20:39
@emasab emasab requested review from a team as code owners July 2, 2025 20:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Confluent Kafka Go client and its underlying librdkafka dependency to v2.11.0-RC3, updates all related build constants, docs, and CI settings, and adds a new changelog entry for the release candidate.

  • Updated dependency versions in go.mod files across modules, examples, and tests
  • Regenerated API HTML and doc-gen script with the new tag and Go version
  • Bumped librdkafka version macros, build info constants, CI env var, README, and CHANGELOG

Reviewed Changes

Copilot reviewed 19 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
soaktest/go.mod Bump confluent-kafka-go dependency to v2.11.0-RC3
kafkatest/go.mod Bump confluent-kafka-go dependency to v2.11.0-RC3
examples/*/go.mod (multiple) Bump examples’ go.mod to v2.11.0-RC3
mk/doc-gen.py Update doc-gen tag to v2.11.0-RC3
schemaregistry/api.html Update links and Go version to reflect new tag
kafka/librdkafka_vendor/rdkafka.h Bump RD_KAFKA_VERSION to 0x020b00ff
kafka/00version.go Update MIN_RD_KAFKA_VERSION and error strings
kafka/build_*.go (multiple) Update LibrdkafkaLinkInfo for various platforms
kafka/generated_errors.go Regenerate errors for librdkafka v2.11.0-RC3
README.md Update supported librdkafka version text
CHANGELOG.md Add v2.11.0 changelog section
.semaphore/semaphore.yml Bump LIBRDKAFKA_VERSION env to v2.11.0-RC3
Comments suppressed due to low confidence (1)

kafka/librdkafka_vendor/rdkafka.h:5320

  • [nitpick] The @remark block appears after the @return tag; consider placing remarks before @return to keep the doc comment structure consistent.
 * @remark The comparison is case-insensitive. 
// ErrTelemetryTooLarge Broker: Client sent a push telemetry request larger than the maximum size the broker will accept
ErrTelemetryTooLarge ErrorCode = C.RD_KAFKA_RESP_ERR_TELEMETRY_TOO_LARGE
// ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata.
// ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata
Copy link

Copilot AI Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is missing a period at the end to match the punctuation style of other error descriptions.

Suggested change
// ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata
// ErrRebootstrapRequired Broker: Client metadata is stale, client should rebootstrap to obtain new metadata.
Copilot uses AI. Check for mistakes.
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Tested locally with integration and other tests too.

@milindl
Copy link
Contributor

milindl commented Jul 3, 2025

I can reproduce the segfault in the tests however

// Best practice is to use dynamic linking if
// librdkafka plugins are used,
// as otherwise the statically linked version of librdkafka
// needs to correspond to the dinamically linked one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Just 'dynamically'

@sonarqube-confluent
Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (55.50% Estimated after merge)
  • Duplications No duplication information (1.30% Estimated after merge)

Project ID: confluent-kafka-go

View in SonarQube

@emasab emasab merged commit 9ab752d into master Jul 3, 2025
2 of 3 checks passed
@emasab emasab deleted the import_v2.11.0-RC3 branch July 3, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants