Latin1fix #89
Merged
Latin1fix #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #89 +/- ## ========================================== + Coverage 85.36% 87.50% +2.13% ========================================== Files 3 3 Lines 41 48 +7 Branches 6 6 ========================================== + Hits 35 42 +7 Misses 4 4 Partials 2 2 ☔ View full report in Codecov by Sentry. |
z4kn4fein approved these changes Dec 20, 2023
|
endret reviewed Dec 20, 2023
| return void 0; | ||
| } | ||
| | ||
| private b64EncodeUnicode(str: string): string { |
There was a problem hiding this comment.
Does it make sense to move these methods into js-common ?
There was a problem hiding this comment.
It is not used in Node :D So it's not that common :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
The localstorage cache is not working with non Latin 1 characters.
Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.
Related issues (only if applicable)
Provide links to issues relating to this pull request
Requirement checklist (only if applicable)