FirebaseAuth: rename ActionCodeOperation enumerations #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These should be prefix stripped and lowercased as per the omit-needless-words approach.
compnerd pushed a commit that referenced this pull request Nov 20, 2023
Better match the reference API for the structure of the listener callback as well as what things are nullable coming out of the listener API. We were always returning a handler from the add function, but for some reason had the function marked as returning an optional incorrectly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These should be prefix stripped and lowercased as per the omit-needless-words approach.