firebase: remove shims.cc #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove this in favour of a prebuilt with the applied changes as we need other alterations for supporting the callback handling of the Firebase future type.
compnerd pushed a commit that referenced this pull request Nov 16, 2023
This adds the add and remove APIs for auth state listener. Should fix WPP-727. We've had to allocate our custom subclass on the heap since we want to make it appear as if this type is actually the base `AuthStateListener` instead of our subclass' type. This is important since you will be unable to actually register the listener with the Firebase Auth API unless Swift's interop can figure out that it _is_ an `AuthStateListener`. Additionally, we've opted to keep the API that requires explicit de-registration of a listener handler, it's a little annoying (since we could also de-register when our opaque type de-initializes) but though it was better to have a 1:1 mapping from the what the underlying SDK expects and what we're providing to the Swift consumer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove this in favour of a prebuilt with the applied changes as we need other alterations for supporting the callback handling of the Firebase future type.