docs: update the README for current instructions #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Update the README.md as the build has now stabilised a bit and new functionality is merged.
brianmichel approved these changes Aug 14, 2023
compnerd pushed a commit that referenced this pull request Oct 19, 2023
Internally, the Firebase SDK uses some Objective-C → Swift magic with `NS_ERROR_ENUM` to generate a bunch of NSErrors which will get bridges into Swift, so it expects some of those functions to be there as if it were an NSError. Unfortunately they give this NSError a Swift type that's a little confusing with `NS_SWIFT_NAME(AuthErrorCode)` so our error object is actually called `AuthErrorCode` which we need to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update the README.md as the build has now stabilised a bit and new functionality is merged.