Avoid use of experimental features #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Avoid the use of `package` visibility as this is not yet generally available and triggers an assertion failure in some cases. Mark the previously package visibility initialiser as an Error SPI.
brianmichel approved these changes Aug 29, 2023
compnerd pushed a commit that referenced this pull request Nov 27, 2023
Cleaning up unused return values, parameters that can be `const`s, and an unneeded empty line that was missed in a previous change set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Avoid the use of
packagevisibility as this is not yet generally available and triggers an assertion failure in some cases. Mark the previously package visibility initialiser as an Error SPI.