FirebaseCore: remove workaround for imported enumeration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This has been resolved in main, remove the workaround and directly use the enumeration values to avoid matching the values.
brianmichel approved these changes Aug 11, 2023
compnerd pushed a commit that referenced this pull request Oct 16, 2023
* Add custom initializer for file configuration * Remove errant logger setting * Add missing newline * Create data out of path and then load into various formats as needed * Memory map the file and just guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This has been resolved in main, remove the workaround and directly use the enumeration values to avoid matching the values.