Skip to content

Static linux #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
snoyberg merged 1 commit into from
Apr 23, 2020
Merged

Static linux #5267

snoyberg merged 1 commit into from
Apr 23, 2020

Conversation

@snoyberg
Copy link
Contributor

@snoyberg snoyberg commented Apr 21, 2020 •
edited
Loading

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!
@snoyberg snoyberg force-pushed the static-linux branch 2 times, most recently from 8983f2d to 2db6983 Compare April 21, 2020 07:09
@snoyberg snoyberg marked this pull request as ready for review April 21, 2020 07:09
@snoyberg snoyberg force-pushed the static-linux branch 2 times, most recently from b6860df to 88bd6cd Compare April 21, 2020 07:29
@snoyberg
Copy link
Contributor Author

snoyberg commented Apr 21, 2020 •
edited
Loading

  • Initial review of CI output makes it look like the nightly Linux job is not doing a static build, need to investigate
@snoyberg
Copy link
Contributor Author

snoyberg commented Apr 21, 2020

This all works perfectly.... except that the executable in the Linux artifact segfaults!?! Investigating...
@snoyberg
Copy link
Contributor Author

snoyberg commented Apr 21, 2020

It was the stripping! 4a53af2
@snoyberg snoyberg requested a review from borsboom April 21, 2020 18:38
@snoyberg
Copy link
Contributor Author

snoyberg commented Apr 21, 2020

Not sure why stripping a static executable makes it segfault, but other than that this is ready for review and potential merge.
borsboom
borsboom reviewed Apr 21, 2020
View reviewed changes
@snoyberg
Copy link
Contributor Author

snoyberg commented Apr 22, 2020

New version ready for review. I'd like to rebase before merge; let me know if you'd rather I rebase before your next review.
borsboom
borsboom reviewed Apr 22, 2020
View reviewed changes
@snoyberg
Copy link
Contributor Author

snoyberg commented Apr 23, 2020

Thanks for the review, looks like we've hit all comments. I'm going to rebase, and then merge once CI passes.
@snoyberg snoyberg merged commit 59d143d into rc/v2.3 Apr 23, 2020
@snoyberg snoyberg deleted the static-linux branch April 23, 2020 04:45
@f-f f-f mentioned this pull request Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@snoyberg @borsboom